Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP and K8s [HZG-5] #1115

Merged
merged 15 commits into from
May 17, 2024
Merged

CP and K8s [HZG-5] #1115

merged 15 commits into from
May 17, 2024

Conversation

gbarnett-hz
Copy link
Contributor

@gbarnett-hz gbarnett-hz commented May 17, 2024

No description provided.

@gbarnett-hz gbarnett-hz marked this pull request as draft May 17, 2024 12:50
Copy link

netlify bot commented May 17, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 85e7c05
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/66477926addf3200080871c0
😎 Deploy Preview https://deploy-preview-1115--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gbarnett-hz gbarnett-hz changed the title CP and K8s [HZ-4746] CP and K8s [HZG-5] May 17, 2024
@gbarnett-hz gbarnett-hz marked this pull request as ready for review May 17, 2024 14:15
Copy link
Contributor

@rebekah-lawrence rebekah-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitty picky things only.

docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
docs/modules/cp-subsystem/pages/cp-subsystem.adoc Outdated Show resolved Hide resolved
gbarnett-hz and others added 4 commits May 17, 2024 16:16
Adopt - suggestion on  IMPORTANT Helm wording

Co-authored-by: rebekah-lawrence <[email protected]>
Adopt - suggestion on  configuration wording

Co-authored-by: rebekah-lawrence <[email protected]>
More suggestions adopted.

Co-authored-by: rebekah-lawrence <[email protected]>
Adopt limitation wording.

Co-authored-by: rebekah-lawrence <[email protected]>
gbarnett-hz and others added 2 commits May 17, 2024 16:28
data-load-timeout-seconds suggestion

Co-authored-by: rebekah-lawrence <[email protected]>
Copy link
Contributor

@rebekah-lawrence rebekah-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbarnett-hz gbarnett-hz merged commit 588af08 into hazelcast:main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants